[#2532][#2512] fix(IT): fix the web e2e test errors when running on the github actions #2534

ch3yne · 2024-03-14T09:10:50Z

What changes were proposed in this pull request?

Fix web e2e test running.

Testing on GitHub actions will result in errors, but it doesn't happen locally. It's probably due to performance issues in the testing environment causing the frontend delay animation to take longer than expected.

Why are the changes needed?

Fix: #2532
Fix: #2512

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

Github Actions

jerryshao · 2024-03-14T21:25:16Z

What is the exact issue here, can we just add more descriptions about the problem and how do we fix it?

...est/java/com/datastrato/gravitino/integration/test/web/ui/utils/ChromeWebDriverProvider.java

…loading for each small module (#2574) ### What changes were proposed in this pull request? 1. Displaying a fallback while content is loading for the main content Displaying a fallback while content is loading for metalakes list table body module Displaying a fallback while content is loading for catalog tree list modul ![UILoading](https://github.com/datastrato/gravitino/assets/9210625/0911c818-ee1b-400d-9b58-3af764a59363) 2. Define metadata icon src path based on the operating environment 3. Fix some issue of inconsistent behaviour - Smooth display of loaded data - Preserve search parameters when strongly refreshing a page ![fixbugs](https://github.com/datastrato/gravitino/assets/9210625/dd94fce7-4ee0-4c76-a40e-94e4a87f5ecc) ### Why are the changes needed? An instant loading state is fallback UI that is shown immediately upon navigation. You can pre-render loading indicators such as skeletons and spinners. This helps users understand the app is responding and provides a better user experience. Fix issue because of the need for consistent behaviour after refactoring Fix: #2570, #2559 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? Will run e2e test after PR #2534 merged --------- Co-authored-by: CHEYNE <[email protected]>

LauraXia123 · 2024-03-21T09:38:48Z

LGTM, Thanks @ch3yne

xunliu · 2024-03-21T09:57:51Z

...test/src/test/java/com/datastrato/gravitino/integration/test/web/ui/utils/AbstractWebIT.java

+      Actions action = new Actions(driver);
+      action.moveToElement(element).click().build().perform();
+      Thread.sleep(ACTION_SLEEP_MILLIS);
+      LOG.error(e.getMessage(), e);


Why not throw exception? only print error log.

There's no need to print error messages here, I removed that line and added a comment.

xunliu · 2024-03-21T10:00:33Z

...test/src/test/java/com/datastrato/gravitino/integration/test/web/ui/utils/AbstractWebIT.java

+  @BeforeEach
+  public void beforeEachTest() {
+    try {
+      Thread.sleep(ACTION_SLEEP_MILLIS);


I think better change variable name ACTION_SLEEP_MILLIS to EACH_TEST_SLEEP_MILLIS

xunliu · 2024-03-21T10:02:40Z

...-test/src/test/java/com/datastrato/gravitino/integration/test/web/ui/pages/MetalakePage.java

@@ -89,8 +84,14 @@ public void setMetalakeCommentField(String commentField) {
  }

  public void setQueryInput(String queryInput) {


I think better change function and variable name QueryInput to QueryParams.

xunliu · 2024-03-21T10:04:58Z

...-test/src/test/java/com/datastrato/gravitino/integration/test/web/ui/pages/MetalakePage.java

-  //  }
+  public boolean verifyLinkToCatalogsPage(String name) {
+    try {
+      String xpath = "//a[@data-refer='metalake-name-link']";


Can we define a link element variable in class member?

xunliu · 2024-03-21T10:05:57Z

...-test/src/test/java/com/datastrato/gravitino/integration/test/web/ui/pages/MetalakePage.java

-    WebElement noMetalakeRows = driver.findElement(By.xpath(xpath));
+    try {
+      String xpath =
+          "//div[@data-refer='metalake-table-grid']//div[contains(@class, 'MuiDataGrid-overlay')]";


Can we define a link element variable in class member?

xunliu · 2024-03-21T10:06:15Z

...-test/src/test/java/com/datastrato/gravitino/integration/test/web/ui/pages/MetalakePage.java

+  public boolean checkIsErrorName() throws InterruptedException {
+    try {
+      String xpath = "//div[@data-refer='metalake-name-field']";
+      WebElement nameField = driver.findElement(By.xpath(xpath));


Can we define a link element variable in class member?

xunliu

LGTM

… content is loading for each small module (apache#2574) ### What changes were proposed in this pull request? 1. Displaying a fallback while content is loading for the main content Displaying a fallback while content is loading for metalakes list table body module Displaying a fallback while content is loading for catalog tree list modul ![UILoading](https://github.com/datastrato/gravitino/assets/9210625/0911c818-ee1b-400d-9b58-3af764a59363) 2. Define metadata icon src path based on the operating environment 3. Fix some issue of inconsistent behaviour - Smooth display of loaded data - Preserve search parameters when strongly refreshing a page ![fixbugs](https://github.com/datastrato/gravitino/assets/9210625/dd94fce7-4ee0-4c76-a40e-94e4a87f5ecc) ### Why are the changes needed? An instant loading state is fallback UI that is shown immediately upon navigation. You can pre-render loading indicators such as skeletons and spinners. This helps users understand the app is responding and provides a better user experience. Fix issue because of the need for consistent behaviour after refactoring Fix: apache#2570, apache#2559 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? Will run e2e test after PR apache#2534 merged --------- Co-authored-by: CHEYNE <[email protected]>

…running on the github actions (apache#2534) ### What changes were proposed in this pull request? Fix web e2e test running. Testing on GitHub actions will result in errors, but it doesn't happen locally. It's probably due to performance issues in the testing environment causing the frontend delay animation to take longer than expected. ### Why are the changes needed? Fix: apache#2532 Fix: apache#2512 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? Github Actions

ch3yne self-assigned this Mar 14, 2024

ch3yne force-pushed the fix-web-e2e branch from d9153b6 to 938067a Compare March 14, 2024 09:12

ch3yne changed the title ~~fix test actions running~~ [#2532] fix(IT): fix test actions running Mar 14, 2024

xunliu mentioned this pull request Mar 14, 2024

[#2536] hotfix(IT): disable web e2e tests temporarily until the actions running error is fixed #2537

Merged

ch3yne force-pushed the fix-web-e2e branch from 3caef55 to 4c8cb21 Compare March 14, 2024 15:13

ch3yne marked this pull request as draft March 14, 2024 16:13

ch3yne force-pushed the fix-web-e2e branch from 740b65a to 64e5672 Compare March 17, 2024 21:14

ch3yne marked this pull request as ready for review March 18, 2024 02:50

ch3yne force-pushed the fix-web-e2e branch 2 times, most recently from 37064ac to cefcdc2 Compare March 18, 2024 10:25

LauraXia123 mentioned this pull request Mar 18, 2024

[#2570][#2559][#2567][#2565] refactor(web): Displaying a fallback while content is loading for each small module, upgrade axios to v1.6.8 #2574

Merged

ch3yne commented Mar 18, 2024

View reviewed changes

...est/java/com/datastrato/gravitino/integration/test/web/ui/utils/ChromeWebDriverProvider.java Outdated Show resolved Hide resolved

ch3yne requested review from xunliu and LauraXia123 March 18, 2024 13:08

ch3yne force-pushed the fix-web-e2e branch from 35578e7 to 0317f7b Compare March 19, 2024 07:35

ch3yne changed the title ~~[#2532] fix(IT): fix test actions running~~ [#2532] fix(IT): fix the web e2e test errors when running on the github actions Mar 19, 2024

ch3yne force-pushed the fix-web-e2e branch 12 times, most recently from d3cf71b to 15d2509 Compare March 20, 2024 04:53

ch3yne added 15 commits March 21, 2024 17:28

improve after test view details click close button

8303b58

modified metalake link selector

5f39dbc

add selenium wait

eebe715

modified metalake link selector

e92c93c

move metalake name link define position

3efd25f

add props no sandbox

1d779dd

redefine metalake link

733224f

remove add arguments for test

9431d11

add log

a1221d5

remove disabled

865e1c6

LOG

1982bc1

add query

02d8727

modified id to data-refer

6c64326

remove unnecessary function

e56fb79

remove argument no sandbox

42665ea

ch3yne force-pushed the fix-web-e2e branch from 4c3668d to 42665ea Compare March 21, 2024 09:53

xunliu reviewed Mar 21, 2024

View reviewed changes

improve the suggestions

ad1b2a2

ch3yne force-pushed the fix-web-e2e branch from 8a99732 to ad1b2a2 Compare March 21, 2024 10:54

ch3yne closed this Mar 21, 2024

ch3yne added the debug action label Mar 21, 2024

ch3yne reopened this Mar 21, 2024

ch3yne closed this Mar 21, 2024

ch3yne removed the debug action label Mar 21, 2024

ch3yne reopened this Mar 21, 2024

xunliu approved these changes Mar 21, 2024

View reviewed changes

xunliu merged commit 5ceb2b8 into apache:main Mar 21, 2024
34 of 46 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#2532][#2512] fix(IT): fix the web e2e test errors when running on the github actions #2534

[#2532][#2512] fix(IT): fix the web e2e test errors when running on the github actions #2534

ch3yne commented Mar 14, 2024 •

edited

Loading

jerryshao commented Mar 14, 2024

LauraXia123 commented Mar 21, 2024

xunliu Mar 21, 2024 •

edited

Loading

ch3yne Mar 21, 2024

xunliu Mar 21, 2024

ch3yne Mar 21, 2024

xunliu Mar 21, 2024

ch3yne Mar 21, 2024

xunliu Mar 21, 2024

ch3yne Mar 21, 2024

xunliu Mar 21, 2024

xunliu Mar 21, 2024

ch3yne Mar 21, 2024

xunliu left a comment

		@@ -89,8 +84,14 @@ public void setMetalakeCommentField(String commentField) {
		}

		public void setQueryInput(String queryInput) {

[#2532][#2512] fix(IT): fix the web e2e test errors when running on the github actions #2534

[#2532][#2512] fix(IT): fix the web e2e test errors when running on the github actions #2534

Conversation

ch3yne commented Mar 14, 2024 • edited Loading

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

jerryshao commented Mar 14, 2024

LauraXia123 commented Mar 21, 2024

xunliu Mar 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xunliu left a comment

Choose a reason for hiding this comment

ch3yne commented Mar 14, 2024 •

edited

Loading

xunliu Mar 21, 2024 •

edited

Loading